Skip to content

[memorygc](lrucache) do not prune memory if prune is disabled#59478

Merged
yiguolei merged 2 commits intoapache:masterfrom
yiguolei:fix_prune
Dec 31, 2025
Merged

[memorygc](lrucache) do not prune memory if prune is disabled#59478
yiguolei merged 2 commits intoapache:masterfrom
yiguolei:fix_prune

Conversation

@yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Dec 30, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei
Copy link
Contributor Author

yiguolei commented Dec 30, 2025

run buildall

mrhhsg
mrhhsg previously approved these changes Dec 30, 2025
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 30, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei added the usercase Important user case type label label Dec 30, 2025
airborne12
airborne12 approved these changes Dec 30, 2025
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

doris-robot commented Dec 30, 2025

TPC-H: Total hot run time: 35657 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4cae0a01433c375d40777bd0c78749e462a7722b, data reload: false

------ Round 1 ----------------------------------
q1	17619	4277	4053	4053
q2	2060	364	240	240
q3	10135	1301	750	750
q4	10225	971	338	338
q5	7542	2154	1978	1978
q6	197	171	138	138
q7	968	803	675	675
q8	9284	1411	1128	1128
q9	6930	5291	5235	5235
q10	6842	1844	1442	1442
q11	513	348	295	295
q12	738	723	585	585
q13	17786	3923	3076	3076
q14	295	293	274	274
q15	591	523	511	511
q16	711	706	635	635
q17	744	768	596	596
q18	7533	7705	8028	7705
q19	1104	1076	649	649
q20	455	379	260	260
q21	4629	4275	3998	3998
q22	1155	1096	1146	1096
Total cold run time: 108056 ms
Total hot run time: 35657 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4338	4252	4222	4222
q2	338	403	331	331
q3	2233	2860	2439	2439
q4	1443	1857	1401	1401
q5	4758	4246	4514	4246
q6	212	166	127	127
q7	2055	1890	1844	1844
q8	2531	2415	2348	2348
q9	7096	7218	7169	7169
q10	2452	2836	2325	2325
q11	557	492	449	449
q12	722	732	573	573
q13	3396	3822	3098	3098
q14	272	281	263	263
q15	523	482	497	482
q16	628	651	603	603
q17	1077	1225	1297	1225
q18	7492	7452	7260	7260
q19	909	870	911	870
q20	1939	1952	1811	1811
q21	4520	4261	4127	4127
q22	1145	1052	995	995
Total cold run time: 50636 ms
Total hot run time: 48208 ms

@doris-robot
Copy link

doris-robot commented Dec 30, 2025

TPC-DS: Total hot run time: 174785 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4cae0a01433c375d40777bd0c78749e462a7722b, data reload: false

query5	5657	582	479	479
query6	327	219	215	215
query7	4239	454	268	268
query8	340	246	234	234
query9	8771	2632	2611	2611
query10	549	366	321	321
query11	15202	14998	14883	14883
query12	184	113	113	113
query13	1256	496	379	379
query14	7203	2968	2745	2745
query14_1	2620	2602	2653	2602
query15	207	192	175	175
query16	999	486	460	460
query17	1183	666	559	559
query18	2682	426	336	336
query19	222	219	196	196
query20	129	117	117	117
query21	216	138	117	117
query22	4213	4143	4229	4143
query23	16160	15535	15280	15280
query23_1	15373	15501	15558	15501
query24	7156	1634	1205	1205
query24_1	1219	1189	1223	1189
query25	527	446	396	396
query26	1247	264	163	163
query27	2750	456	320	320
query28	4521	2187	2175	2175
query29	737	520	446	446
query30	305	243	210	210
query31	798	634	589	589
query32	80	70	68	68
query33	527	348	281	281
query34	880	883	538	538
query35	736	790	702	702
query36	806	877	817	817
query37	127	91	75	75
query38	2692	2704	2662	2662
query39	776	739	728	728
query39_1	708	715	715	715
query40	213	131	122	122
query41	66	64	62	62
query42	106	102	105	102
query43	447	444	425	425
query44	1361	769	756	756
query45	190	181	177	177
query46	858	950	606	606
query47	1427	1504	1393	1393
query48	325	329	245	245
query49	603	418	332	332
query50	634	272	209	209
query51	3734	3778	3770	3770
query52	104	107	103	103
query53	297	330	273	273
query54	284	254	244	244
query55	78	80	70	70
query56	283	292	299	292
query57	1023	1041	938	938
query58	272	253	255	253
query59	2178	2193	2092	2092
query60	309	309	294	294
query61	182	191	200	191
query62	408	381	327	327
query63	305	272	276	272
query64	4889	1296	1036	1036
query65	3836	3679	3719	3679
query66	1354	431	319	319
query67	15010	15796	14866	14866
query68	2807	1033	765	765
query69	449	351	316	316
query70	1037	939	919	919
query71	320	298	290	290
query72	6343	4754	4981	4754
query73	496	558	312	312
query74	8811	8737	8625	8625
query75	2866	2922	2522	2522
query76	2872	1086	659	659
query77	355	362	307	307
query78	9872	9999	9202	9202
query79	1096	919	606	606
query80	690	631	517	517
query81	491	269	241	241
query82	1342	152	117	117
query83	272	271	246	246
query84	258	128	105	105
query85	944	528	463	463
query86	322	297	328	297
query87	2846	2869	2752	2752
query88	3290	2293	2283	2283
query89	383	349	328	328
query90	1717	156	147	147
query91	179	171	142	142
query92	74	72	63	63
query93	979	910	568	568
query94	449	319	275	275
query95	542	385	307	307
query96	589	463	214	214
query97	2330	2405	2283	2283
query98	218	198	200	198
query99	604	591	484	484
Total cold run time: 250200 ms
Total hot run time: 174785 ms

@doris-robot
Copy link

doris-robot commented Dec 30, 2025

ClickBench: Total hot run time: 26.83 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4cae0a01433c375d40777bd0c78749e462a7722b, data reload: false

query1	0.06	0.05	0.05
query2	0.11	0.05	0.05
query3	0.26	0.08	0.08
query4	1.61	0.11	0.12
query5	0.26	0.26	0.26
query6	1.15	0.67	0.65
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.57	0.49	0.51
query10	0.55	0.54	0.53
query11	0.15	0.11	0.11
query12	0.16	0.13	0.13
query13	0.61	0.60	0.59
query14	0.99	0.97	0.98
query15	0.80	0.80	0.80
query16	0.40	0.42	0.42
query17	1.05	1.06	1.05
query18	0.23	0.21	0.21
query19	1.86	1.85	1.78
query20	0.02	0.01	0.02
query21	15.44	0.28	0.14
query22	4.83	0.05	0.05
query23	16.06	0.29	0.10
query24	2.08	0.30	0.21
query25	0.08	0.06	0.07
query26	0.14	0.13	0.13
query27	0.06	0.06	0.05
query28	4.19	1.05	0.88
query29	12.60	3.93	3.13
query30	0.28	0.13	0.11
query31	2.84	0.62	0.38
query32	3.23	0.55	0.47
query33	2.93	2.97	3.09
query34	16.69	5.15	4.48
query35	4.52	4.51	4.51
query36	0.67	0.49	0.48
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.02	0.02
query40	0.16	0.14	0.12
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.04
Total cold run time: 98.11 s
Total hot run time: 26.83 s

@yiguolei
Copy link
Contributor Author

yiguolei commented Dec 30, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 30, 2025

BE UT Coverage Report

Increment line coverage 20.00% (1/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.37% (18951/35508)
Line Coverage 39.26% (175894/448066)
Region Coverage 33.80% (136032/402445)
Branch Coverage 34.75% (58770/169140)

@doris-robot
Copy link

doris-robot commented Dec 30, 2025

TPC-H: Total hot run time: 34147 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4d27a6b77a0e87aa9bb7a0acecb94b1d8feb214c, data reload: false

------ Round 1 ----------------------------------
q1	17644	4204	4050	4050
q2	2069	346	235	235
q3	10150	1271	723	723
q4	10233	902	337	337
q5	7525	2110	1981	1981
q6	189	175	142	142
q7	933	788	670	670
q8	9282	1421	1105	1105
q9	6927	5164	5148	5148
q10	6846	1840	1404	1404
q11	516	309	309	309
q12	722	737	576	576
q13	17785	3836	3103	3103
q14	289	295	276	276
q15	600	504	506	504
q16	714	674	636	636
q17	718	759	627	627
q18	7504	7111	7348	7111
q19	1105	953	603	603
q20	416	366	256	256
q21	4361	3914	3366	3366
q22	1063	1013	985	985
Total cold run time: 107591 ms
Total hot run time: 34147 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4082	4065	4099	4065
q2	345	393	308	308
q3	2078	2589	2217	2217
q4	1315	1746	1317	1317
q5	4053	3943	4885	3943
q6	217	182	130	130
q7	2027	1964	1782	1782
q8	2570	2390	2388	2388
q9	7134	7377	7203	7203
q10	2575	2692	2278	2278
q11	660	469	467	467
q12	701	728	618	618
q13	3508	4053	3357	3357
q14	289	315	299	299
q15	533	493	571	493
q16	796	683	647	647
q17	1131	1290	1360	1290
q18	7723	7767	7607	7607
q19	912	916	954	916
q20	2069	2070	1912	1912
q21	4682	4538	4345	4345
q22	1156	1081	1072	1072
Total cold run time: 50556 ms
Total hot run time: 48654 ms

@doris-robot
Copy link

doris-robot commented Dec 30, 2025

TPC-DS: Total hot run time: 174045 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4d27a6b77a0e87aa9bb7a0acecb94b1d8feb214c, data reload: false

query5	4409	601	458	458
query6	332	220	214	214
query7	4209	459	265	265
query8	330	242	236	236
query9	8732	2613	2651	2613
query10	540	375	314	314
query11	15250	15236	14787	14787
query12	177	114	120	114
query13	1257	506	424	424
query14	5722	2946	2685	2685
query14_1	2644	2617	2630	2617
query15	201	198	186	186
query16	988	474	460	460
query17	1107	709	585	585
query18	2427	443	343	343
query19	230	220	208	208
query20	121	115	116	115
query21	232	163	133	133
query22	3822	4109	3967	3967
query23	15958	15572	15259	15259
query23_1	15507	15340	15436	15340
query24	7422	1583	1191	1191
query24_1	1254	1191	1226	1191
query25	560	483	421	421
query26	1259	262	178	178
query27	2759	460	304	304
query28	4527	2212	2190	2190
query29	831	552	467	467
query30	319	244	214	214
query31	766	639	552	552
query32	95	70	71	70
query33	553	362	297	297
query34	912	883	572	572
query35	790	784	695	695
query36	863	868	860	860
query37	132	95	81	81
query38	2712	2679	2625	2625
query39	778	767	712	712
query39_1	711	714	695	695
query40	217	135	116	116
query41	65	62	65	62
query42	107	101	106	101
query43	428	461	411	411
query44	1339	762	751	751
query45	183	181	174	174
query46	854	966	603	603
query47	1315	1356	1309	1309
query48	316	327	260	260
query49	605	409	331	331
query50	654	280	224	224
query51	3793	3781	3777	3777
query52	99	108	97	97
query53	293	324	266	266
query54	299	256	244	244
query55	79	74	69	69
query56	294	287	300	287
query57	959	1009	889	889
query58	273	256	250	250
query59	2096	2140	2200	2140
query60	352	313	293	293
query61	166	161	158	158
query62	413	347	309	309
query63	300	270	279	270
query64	5116	1304	1007	1007
query65	3756	3716	3708	3708
query66	1464	423	306	306
query67	15268	15127	14746	14746
query68	7954	994	717	717
query69	529	346	303	303
query70	1052	972	920	920
query71	371	297	282	282
query72	5848	4653	4752	4653
query73	653	535	311	311
query74	8745	8691	8531	8531
query75	2897	2879	2514	2514
query76	3873	1059	658	658
query77	522	367	283	283
query78	9738	9786	9055	9055
query79	1386	931	602	602
query80	709	571	498	498
query81	500	264	230	230
query82	214	138	109	109
query83	268	265	241	241
query84	254	119	108	108
query85	915	535	457	457
query86	413	327	325	325
query87	2846	2810	2728	2728
query88	3617	2282	2283	2282
query89	391	349	327	327
query90	2244	158	153	153
query91	179	173	146	146
query92	93	65	63	63
query93	1885	931	562	562
query94	580	331	276	276
query95	569	394	312	312
query96	595	477	207	207
query97	2336	2365	2265	2265
query98	232	203	196	196
query99	558	568	508	508
Total cold run time: 254287 ms
Total hot run time: 174045 ms

@doris-robot
Copy link

doris-robot commented Dec 30, 2025

ClickBench: Total hot run time: 26.72 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4d27a6b77a0e87aa9bb7a0acecb94b1d8feb214c, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.27	0.09	0.08
query4	1.62	0.11	0.11
query5	0.26	0.27	0.26
query6	1.16	0.66	0.64
query7	0.04	0.03	0.02
query8	0.05	0.04	0.04
query9	0.57	0.52	0.50
query10	0.54	0.55	0.53
query11	0.15	0.11	0.11
query12	0.16	0.13	0.12
query13	0.61	0.59	0.60
query14	0.99	0.98	0.97
query15	0.81	0.78	0.80
query16	0.42	0.39	0.40
query17	1.04	1.00	1.07
query18	0.23	0.21	0.21
query19	1.93	1.83	1.71
query20	0.01	0.02	0.01
query21	15.48	0.29	0.15
query22	4.80	0.05	0.05
query23	16.05	0.29	0.10
query24	1.51	0.54	0.26
query25	0.08	0.06	0.07
query26	0.14	0.14	0.14
query27	0.08	0.05	0.06
query28	3.44	1.06	0.91
query29	12.60	3.94	3.13
query30	0.27	0.14	0.12
query31	2.84	0.60	0.38
query32	3.23	0.56	0.47
query33	2.99	3.01	3.04
query34	16.89	5.12	4.45
query35	4.50	4.42	4.47
query36	0.66	0.50	0.50
query37	0.11	0.07	0.07
query38	0.07	0.04	0.03
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.08	0.03	0.03
query42	0.05	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 97.15 s
Total hot run time: 26.72 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 30, 2025

BE Regression && UT Coverage Report

Increment line coverage 20.00% (1/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.12% (25035/34713)
Line Coverage 58.83% (262903/446874)
Region Coverage 53.51% (217591/406608)
Branch Coverage 55.16% (93608/169702)

@yiguolei
Copy link
Contributor Author

yiguolei commented Dec 31, 2025

skip check_coverage

@yiguolei yiguolei merged commit 26fb988 into apache:master Dec 31, 2025
31 of 34 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 31, 2025
@yiguolei
[memorygc](lrucache) do not prune memory if prune is disabled (#59478)
65206b0 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Dec 31, 2025
Closed
github-actions bot pushed a commit that referenced this pull request Dec 31, 2025
@yiguolei
[memorygc](lrucache) do not prune memory if prune is disabled (#59478)
6bd2501 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Dec 31, 2025
Merged
yiguolei added a commit that referenced this pull request Dec 31, 2025
@github-actions @yiguolei
branch-4.0: [memorygc](lrucache) do not prune memory if prune is disa…
708affa 
…bled #59478 (#59501)

Cherry-picked from #59478

Co-authored-by: yiguolei <guolei@selectdb.com>
seawinde pushed a commit to seawinde/doris that referenced this pull request Jan 30, 2026
@yiguolei @gavinchou
[memorygc](lrucache) skip adjust capacity for cache that disable cach…
6cc8d5c 
…e prune apache#59478 (apache#6411)

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12 airborne12 airborne12 approved these changes

@gavinchou gavinchou gavinchou approved these changes

@jacktengg jacktengg jacktengg approved these changes

@mrhhsg mrhhsg mrhhsg left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/4.0.3-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@yiguolei @Thearas @doris-robot @hello-stephen @mrhhsg @airborne12 @gavinchou @jacktengg